Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve skywire-cli vpn subcommand #1389

Merged
merged 5 commits into from
Oct 17, 2022
Merged

improve skywire-cli vpn subcommand #1389

merged 5 commits into from
Oct 17, 2022

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Oct 12, 2022 •
edited
Loading

Did you run make format && make check? Yes

Fixes #1360

Changes:

  • improve skywire-cli vpn start output.
  • fix fetching vpn server list issue.
  • improve getRouteSetupHooks (aka autotransport) logic.

How to test this PR:

  • for skywire-cli vpn start <pk> command, check logs.
  • for vpn list command, on prod visor check skywire-cli vpn list --nofilter command

@mrpalide mrpalide marked this pull request as ready for review October 12, 2022 09:40
@mrpalide mrpalide changed the title [WIP] improve skywire-cli vpn subcommand improve skywire-cli vpn subcommand Oct 14, 2022
@0pcom
Copy link
Collaborator

0pcom commented Oct 16, 2022

I've tested this. Much improved.

I think it would be helpful, once the vpn is actuallly running, to print the ip address that you now have.

@0pcom 0pcom self-requested a review October 17, 2022 19:22
0pcom
0pcom approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@0pcom 0pcom merged commit ddccd7f into skycoin:develop Oct 17, 2022
@mrpalide mrpalide deleted the fix/skywire-cli-vpn-subcommands branch October 20, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @0pcom