skywire-cli terminal user interface improvements #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0pcom
changed the title
…lobal flag to vpn and visor subcommands where it is actually used. Hide json global flag. Remove the last line of the help menu 'for more information about a command'
… rule rm --all -s flag to remove all transports / routing rules. Not fully implemented. make format check
…lp menu text for skywire-visor
|
Before After Before After Before After Before After Before After Before After Before After Before After Before After Before After Before After Ready with this one, now I've left some things commented out which can be implemented after this is merged |
0pcom
changed the title
mrpalide
approved these changes
Oct 20, 2022
cmd/skywire-visor/commands/root.go
Outdated
Comment on lines
340
to
345
| if logLvl != "" { | ||
| if logLvl == "INFO" || logLvl == "DEBUG" || logLvl == "TRACE" { | ||
| log.Info("setting log level to: ", logLvl) | ||
| conf.LogLevel = logLvl | ||
| } | ||
| } |
There was a problem hiding this comment.
Be good if the behave of this condition not limited to capital words, means set info and Info works like INFO. Currently just INFO and TRACE and DEBUG work well.
|
Before
After |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385
Changes:
How to test this PR: