-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-implement setting reward address #1391
Conversation
I've introduced a function to dynamically generate the Long text of the cobra command - to show any existing reward address which is presently configured. An address was chosen randomly from the skycoin explorer for demonstration purposes. The The rpc is now optionally used to set the reward config in the event that
the flag defaults intelligently change along these lines. the default address is now the same as any reward address currently specified, to avoid errant misconfiguration when running the command with no arguments there is one small issue with my re-implementation of the api / rpc that I would ask @ersonp to look at a few more minor changes and this PR will be ready |
…ward to delete reward config / opt out of rewards. fix help menu formatting
…g set & remove it if no valid setting / reward file exists
… populate this field during generation of the file
fix issue on SurveySha256 writefile
add SkywireVersion to survey
since we are moving
displaynodeip
to the visor's conf struct, it is necesary to have that settable via config gen, and to change theconfig priv
subcommand so that it produces the file with the new formatthe json forrmat of the reward address file was dropped, and the filename changed to reward.txt
the format of this file can now be easily reproduced by any user, without needing to use the cli command
the existing
privacyconfig
implementation was either removed or commented outThis PR needs erson's PR for changes to the visor's config struct