Add display node ip field to the main config #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the fiels DisplayNodeIP to the main config in order to send it to the service discovery.
This commit adds a new flag publicip to config gen. We remove the fame flag from priv as it is moved from the private config to the main one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #skywire-services-610
Changes:
display_node_ipto main configdisplay_node_ipfrom private configdisplay_node_ipto Services of service discoveryHow to test this PR:
//replace github.com/skycoin/skywire => ../skywireingo.modand runmake depskywire-servicesbuild integration env"display_node_ip": trueinside"launcher"of the config of visorB and also set"is_public": truehttp://service-discovery:9098/api/services?type=visorand see if the IP of visorB shows not not.