run as systray flag --systray
#1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0pcom
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
very nice work. Extensive changes.
will have to test it on a pi when its merged on develop.
Not to make sure the systray works, but to make sure the hidden dependency error doesn't manifest again if the visor is not run with the systray. If it doesn't we will have to revert or figure something else out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #_
Changes:
--systrayflag on running visor for start as systrayScreencasts:
Windows
screencast-windows.mp4
Mac
screencast-mac.mp4
Linux
xubuntu-screen0.webm
How to test this PR:
make build./skywire-visor -c skywire-config.json./skywire-visor -c skywire-config.json --systray