New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for the UI #1398

Merged

0pcom merged 1 commit into skycoin:develop from Senyoret1:fixes-for-ui

Oct 24, 2022

Contributor

Senyoret1 commented Oct 23, 2022

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

Now the app shows that there are no results when the discovery service returns null.
Now the app reloads well if the user presses the refresh button of the web browser while checking the app list of a node.

How to test this PR:

Now the search tab of the skysocks-client app should show that there are no results, instead of showing the loading animation forever.
If you press the refresh button of the web browser while checking the app list of a node, the page should be reloaded correctly, instead of showing the loading animation forever.


          Bug fixes for the UI

dd2b8c8

0pcom self-requested a review

October 24, 2022 13:27

0pcom approved these changes

View reviewed changes

Collaborator

0pcom left a comment

looks good

0pcom merged commit 700e5d2 into skycoin:develop

Senyoret1 mentioned this pull request

HVUI Wrong service discovery endpoint for skysocks #1397

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet