-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/skywire app example #1409
Merged
Merged
Feat/skywire app example #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds ReserveApp to the RPC and API which will be used to set and get a procID for an external app. We also add Reserve in ProcManager which does Reserves a proc and proc ID and returns back the Proc ID.
This commit updates the func NewClient so that it can work even if a Proc Config is not available in the env. Instead it will take the procAddr from it's parameter. If a Proc Config will be provided in the env then the procAddr param can be left as nil.
This commit fixes Register by adding a go routine to wait for the conn with AwaitConn. We also change the method awaitConn of Proc to globle and add <-p.connCh to wait for the conn to be ready.
…se proxying. Switch subcommands for flags; accept but do not enforce the use of arguments
0pcom
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nicely done
I will come back before the release and update any documentation which needs tobe updated. I've updated the main README for skywire-cli but I see there are other docs included here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?Fixes #
Changes:
How to test this PR:
make build-examples
./skywire-cli config gen -irtm
to create aexample-server-app
entry in configexample-server-app
from UI or CLImake build-examples
example-client-app
by./skywire-cli visor app register -a example-client-app
./app/example-client-app -procKey <proc-key> -addr <visor-a-pk:45>
hi
reply message./skywire-cli visor app deregister -k <proc-key>
Skyproxy
visorA
from this branch on remotego run ./example/http-server/server.go
this will start the app on port9080
visorB
from this branch on local./skywire-cli skyproxy connect <remote-pk> --remoteport 9080 --localport 9000
localhost:9000
on local and access the example http server running on remote./skywire-cli skyproxy ls
./skywire-cli skyproxy disconnect <id>
(get the id from the above step)