Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build options to missing Makefile targets #142

Merged

Conversation

nkryuchkov
Copy link
Contributor

Some build targets in Makefile were missed while implementing #137, and build versions are not stored when using them. This PR adds build options for storing versions to all Makefile targets.

@nkryuchkov nkryuchkov requested a review from jdknives January 30, 2020 12:56
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Well done!

@jdknives jdknives merged commit e4236d6 into skycoin:milestone2 Jan 30, 2020
@nkryuchkov nkryuchkov deleted the fix/missing-makefile-targets branch March 13, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants