Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetRewardAddress API #1438

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Fix GetRewardAddress API #1438

merged 4 commits into from
Jan 19, 2023

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jan 19, 2023 •
edited
Loading

Did you run make format && make check?

Fixes #1435
Fixes #1437
Fixes #1436

Changes:

  • Fixed GetRewardAddress API
  • Added RewardAddress to summary API

How to test this PR:

  1. Delete the rewards file from ./local/reward.txt
  2. Build the PR make build
  3. Run the API http://127.0.0.1:8000/api/visors/<pk>/reward
  4. Check the output
  5. Run the API http://127.0.0.1:8000/api/visors/<pk>/summary
  6. Check the output
  7. Run DELETE http://127.0.0.1:8000/api/visors/<pk>/reward
  8. Check the rewards file at ./local/reward.txt

mrpalide
mrpalide reviewed Jan 19, 2023
View reviewed changes
pkg/visor/api.go Outdated Show resolved Hide resolved
@0pcom 0pcom merged commit 0d588eb into skycoin:develop Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ersonp @mrpalide @0pcom