Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging #1507

Merged
merged 11 commits into from
Mar 23, 2023
Merged

improve logging #1507

merged 11 commits into from
Mar 23, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Mar 5, 2023

Did you run make format && make check? Yes

Fixes #1472 #1473 #1427

Changes:

  • add -l or --store-log flag to skywire-visor for save logs in /local/log/... path as {date}-{start_time}.log file.
  • add --force-color flag to skywire-visor for set ForceColor attribute of formatter true on non-TTY outputs.
  • fix missing logs in /runtime-logs api endpoint
  • fix app logs wrong response is /logs endpoint of apps
  • fix since query filter on /logs

How to test this PR:

  1. run visor as skywire-visor -c skywire-config.json -l, then checking /local/log/ folder.
  2. run visor on non-TTY output with --force-color flag as skywire-visor -c skywire-config.json --force-color
  3. run visor and check logs of visor and specific app like skychat or skysocks

@mrpalide mrpalide changed the title [WIP] improve logging improve logging Mar 5, 2023
@mrpalide mrpalide marked this pull request as ready for review March 5, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants