Change build path of binaries to build folder #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the rules unfix-systray-vendor and bin-fix. This content of the rule bin is moved to bin-fix and the rule unfix-systray-vendor reverts the changes made by fix-systray-vendor. The rule bin now only uses fix-systray-vendor bin-fix unfix-systray-vendor as dependencies in that order.
mrpalide
reviewed
Mar 14, 2023
This commit adds two new rules to the makefile bin1 and bin-root-path. bin1 is used to build the binaries in root. The bin path is also now stored in a vairable called BUILD_PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #
Changes:
rootto./buildHow to test this PR:
make buildcd ./build./skywire-cli config gen -ir./skywire-visormake build1for old functionality i.e. build binaries in root