-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating mechanism for mainnet #153
Updating mechanism for mainnet #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these small things, it is a really great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in the integration env. Really good job man! Would like to give that another test outside of the integration env as soon as test deployment is stable again though.
Also, we need to add support for updating appliations. |
# Conflicts: # go.sum # vendor/modules.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. 👑
# Conflicts: # go.mod
NOTE: After merging this PR, all
git
tags and GitHub releases should be removed because they exist for testing purposes.Did you run
make format && make check
? yesFixes #129
Fixes #141
It should be merged simultaneously with https://github.com/SkycoinPro/skywire-services/pull/84.
Changes:
skywire-visor
andskywire-cli
binary files update via thehypervisor
GET /visors/{pk}/restart
toPOST /visors/{pk}/restart
goreleaser
forskywire-visor
andskywire-cli
How to test this PR:
VERSION := $(shell git describe)
line inMakefile
VERSION := 0.1.0
VisorA
panePOST
request tolocalhost:8080/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update
VisorA
pane andVisorA
is restarted successfully and works. Apps should also work. Versions of all binaries in their output should be updated.200
and body istrue
shell
paneskywire-visor
,skywire-cli
andVisorA
apps binaries are updated and work (e.g. usingls -lah ./bin
)VisorA
sayingRemoving file ...
are removed.