Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating mechanism for mainnet #153

Merged
merged 20 commits into from
Mar 2, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Feb 6, 2020

NOTE: After merging this PR, all git tags and GitHub releases should be removed because they exist for testing purposes.

Did you run make format && make check? yes

Fixes #129
Fixes #141

It should be merged simultaneously with https://github.com/SkycoinPro/skywire-services/pull/84.

Changes:

  • Implement skywire-visor and skywire-cli binary files update via the hypervisor
  • Change GET /visors/{pk}/restart to POST /visors/{pk}/restart
  • Setup goreleaser for skywire-visor and skywire-cli

How to test this PR:

  1. Comment out the VERSION := $(shell git describe) line in Makefile
  2. Add a new line below it: VERSION := 0.1.0
  3. Run the generic integration environment
  4. Go to VisorA pane
  5. Make an HTTP POST request to localhost:8080/api/visors/024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7/update
  6. Check if there are no errors in VisorA pane and VisorA is restarted successfully and works. Apps should also work. Versions of all binaries in their output should be updated.
  7. Check if the HTTP response status is 200 and body is true
  8. Go to shell pane
  9. Check if skywire-visor, skywire-cli and VisorA apps binaries are updated and work (e.g. using ls -lah ./bin)
  10. Check if files/directories from logs from VisorA saying Removing file ... are removed.
  11. Note that in fact, an old version of binaries is uploaded to the last GitHub release. GitHub releases need a clean-up.

@nkryuchkov nkryuchkov changed the title Updating mechanism for main net Updating mechanism for mainnet Feb 7, 2020
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these small things, it is a really great job!

pkg/util/updater/updater.go Outdated Show resolved Hide resolved
pkg/util/updater/updater.go Outdated Show resolved Hide resolved
pkg/util/updater/updater.go Outdated Show resolved Hide resolved
@nkryuchkov nkryuchkov marked this pull request as ready for review February 8, 2020 18:42
@nkryuchkov nkryuchkov changed the title Updating mechanism for mainnet [WIP] Updating mechanism for mainnet Feb 11, 2020
@nkryuchkov nkryuchkov changed the title [WIP] Updating mechanism for mainnet Updating mechanism for mainnet Feb 12, 2020
Copy link
Contributor

@Kifen Kifen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in the integration env. Really good job man! Would like to give that another test outside of the integration env as soon as test deployment is stable again though.

@jdknives
Copy link
Member

Also, we need to add support for updating appliations.

@nkryuchkov nkryuchkov changed the title Updating mechanism for mainnet [WIP] Updating mechanism for mainnet Feb 22, 2020
@nkryuchkov nkryuchkov changed the title [WIP] Updating mechanism for mainnet Updating mechanism for mainnet Feb 27, 2020
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. 👑

@nkryuchkov nkryuchkov merged commit c6e6c7c into skycoin:milestone2 Mar 2, 2020
@nkryuchkov nkryuchkov deleted the feature/update-visor branch March 13, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build binaries on new tag creation Updating mechanism for mainnet
4 participants