Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skywire-utilities dependency - fix skywire-cli vpn list #1546

Merged
merged 4 commits into from
May 9, 2023
Merged

Update skywire-utilities dependency - fix skywire-cli vpn list #1546

merged 4 commits into from
May 9, 2023

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented May 9, 2023

Changes:

  • manually removed skywire-utilities from go.mod, then ran go mod tidy ; go mod vendor to add it back and update skywire-utilities to the latest commits.

Fixes #1543

image

[user@linux skywire]$ go run cmd/*/*cli.go proxy list -n10
02cb4a91b599daac8b86c897fd1f273a40a4e52c98216ae34a42d84380aec7ae34:3 | HK
02aa4893366f4629a91f5f763061feb8e204e4835001c90f4e3393dabbe90e42e4:3 | ID
02a47adc3fd737aa80444fdb7958f1926e3ce878b86218c3b4cec92e2b130f5b55:3 | ID
021d56f4e398eda6b17f3b281d6ffacd702d3f41e0cc3a803ab40c128c27a65479:3 | ID
032ee2c686fef36f89745d8bf5fbaec260707e836c9eff5a2d59859227c551a4ab:3 | ID
02834489bfd832fc00b8e299202b3b33da3f70abbb6975571b5554b14dc99d898d:3 | ID
03cff3eebafd307d0a302308c7f85af2292e1cc310e4157f17086f80ef38734496:3 | ID
03585b9ebfe6d5cd41078a56bea003b8bb577d98eef2b4b220af90ec05277b8a7f:3 | US
02a143bec57860fb3e379276e986910cb3a8d46f9415008f958923639ce9bbed8d:3 | ID
02c3067bce0edde054f03c019632c10e662b9a95c5bc712ea9296f8545300f8d3a:3 | ID
[user@linux skywire]$ go run cmd/*/*cli.go vpn list -n10
03676bc54270d7dca85ccc3248f6a26595319805e3b7ec3f9f615186b7602d0852:44 | ID
020d18ace3964b262f2b8235fe539ea933eaa62b4b9bdc1ef2ed7fc374b04abb1c:44 | ID
02d5e670934b354c6bbbe78ab44baf631ca1f3f951b0a8ba2f6e2907feb3367c58:44 | SG
037c16c5b90a8f07813ffb455a14c340284ce21a0af2432c9955eb5626c96bc3b5:44 | ID
03b13ac4fed2ca5d732e9ad11bd5005d9b2bd358321845b715ff2168238235e6c4:44 | CA
0264d39990f6104b862862c09838f099f592d5494b721eeaea4a953e012eef46c5:44 | ID
027f929f89625037bc0be9a584c6c2d1e64499a5f9249d6c860d04cb13f163cae2:44 | IT
03265333ee78efad8ff03a8078cc417487751c5149c99a37d8af634aa73b8858a0:44 | ID
0338dad3035a7634887a65b955e4f7e3a5708ef4b9632f52e4c59b633a176ba0f8:44 | ID
024bfe6fa8753469661fe80941d619f649a2a466ff1a5b1acb14bacb4cd6b648be:44 | ID

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch and rebuilt the binaries. Ran the skywire-visor with default config from skywire-cli config gen and then ran skywire-cli proxy list. It returned

 ✘ theodork@MinivonTheodor  ~  skywire-cli proxy list
[2023-05-09T16:22:22+02:00] FATAL [skywire-cli]: Failed to connect; is skywire running?: no service of type proxy registered

I dont know if the suggestion that Skywire is not running may be related to the problem, but the call is definitely processed by the running Skywire visor instance. Likely a problem with hardcoding the suggestion.

@0pcom
Copy link
Collaborator Author

0pcom commented May 9, 2023

I dont know if the suggestion that Skywire is not running may be related to the problem, but the call is definitely processed by the running Skywire visor instance. Likely a problem with hardcoding the suggestion.

it means the RPC method was not found.

try like this perhaps

[[ -d apps ]] && sudo rm -r apps || true
mkdir -p apps
echo -e '#!/bin/bash \n go run ../../cmd/apps/skychat/skychat.go' | tee apps/skychat
echo -e '#!/bin/bash \n go run ../../cmd/apps/skysocks/skysocks.go' | tee apps/skysocks
echo -e '#!/bin/bash \n go run ../../cmd/apps/skysocks-client/skysocks-client.go' | tee apps/skysocks-client
echo -e '#!/bin/bash \n go run ../../cmd/apps/vpn-client/vpn-client.go' | tee apps/vpn-client
echo -e '#!/bin/bash \n go run ../../cmd/apps/vpn-server/vpn-server.go' | tee apps/vpn-server
chmod +x ./apps/*
go run cmd/skywire-cli/skywire-cli.go config gen -bixr
sudo go run ./cmd/skywire-visor/skywire-visor.go || true

then try

go run cmd/*/*cli.go proxy list -n10
go run cmd/*/*cli.go vpn list -n10

proxy list was recently added, and I think its not on master ; therefore if you are running a visor without that rpc method it will fail like that

… list ; standardize the implementation of these two subcommands
@0pcom
Copy link
Collaborator Author

0pcom commented May 9, 2023

the last commit adds a direct query of the service discovery and flags to specify service discovery URL and to set direct query (http GET) as the default / (explicit direct query)

@0pcom 0pcom merged commit 2acb5e7 into skycoin:develop May 9, 2023
@0pcom 0pcom deleted the fix-server-list branch May 9, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants