Dmsgpty whitelist #1554
Merged
Dmsgpty whitelist #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1542
The dmsgpty-host whitelist was, until now, only whitelisting the hypervisor ; which is always being dialed and having the rpc served to regardless of the availability or online state of the hypervisor.
By integrating the existing dmsgpty-host whitelist into the visor's config, and adding public keys to the whitelist, it allows for pseudo-terminal (pty) access over dmsg which is explicitly configurable, and avoid constant attempts by the visor to serve rpc to the hypervisor instance.
It should be noted that in having pty access, the rpc of the remote visor may be accessed through the pty via skywire-cli on the remote visor. This is a sufficient substitute for the hypervisor ui interface, in many cases.