New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the js mime type #1576

Merged

0pcom merged 1 commit into skycoin:develop from Senyoret1:js-mime

May 24, 2023

Contributor

Senyoret1 commented May 24, 2023

Did you run make format && make check?
Can’t from my dev enviroment, will fix any problem form another machine if a problem appears.

Changes:

The correct mime type for .js files was added. This is because, on Windows, the server returns “text/plain” as the mime type of the .js files and that does not allow to open the Hypervisor UI, as modern browsers block the excecution if the mime type is not correct. This is similar to a change that was made to the explorer: Update to Go18 skycoin-explorer#424 (comment)

How to test this PR:
Opening the Hypervisor UI from localhost:8000 should work well on Windows.


          Fix the js mime type

0pcom approved these changes

View reviewed changes

Collaborator

0pcom left a comment

looks good

0pcom merged commit f426b20 into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet