Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golangci-lint #1697

Merged
merged 3 commits into from
Dec 18, 2023
Merged

update golangci-lint #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
003cebf
update golangci-lint to 1.55.2
mrpalide Dec 18, 2023
f4291e6
remove depguard from linting list, because of its conflict with golan…
mrpalide Dec 18, 2023
a222887
move from ioutil to os.WriteFile for dmsghttp command
mrpalide Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- uses: actions/checkout@v3
- name: Install Requirements
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.52.1
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.55.2
make dep
chmod +x ./ci_scripts/create-ip-aliases.sh
./ci_scripts/create-ip-aliases.sh
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@v3
- name: Install Requirements
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.52.1
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.55.2
make dep
chmod +x ./ci_scripts/create-ip-aliases.sh
./ci_scripts/create-ip-aliases.sh
Expand All @@ -49,7 +49,7 @@ jobs:
- name: Install Requirements
run: |
choco install make
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.1
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
make dep
- name: Testing
run: |
Expand Down
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ linters:
- megacheck
- misspell
- nakedret
- depguard
enable-all: false
disable-all: true
presets:
Expand Down
3 changes: 1 addition & 2 deletions cmd/skywire-cli/commands/dmsghttp/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"context"
"encoding/json"
"io"
"io/ioutil"
"net/http"
"os"

Expand Down Expand Up @@ -53,7 +52,7 @@ var dmsghttpCmd = &cobra.Command{
log.WithError(err).Error("Error accurs during marshal content to json file")
}

err = ioutil.WriteFile(path, file, 0600)
err = os.WriteFile(path, file, 0600)
if err != nil {
log.WithError(err).Errorf("Cannot save new dmsghttp-config.json file at %s", path)
}
Expand Down
Loading