Improve VPN and Proxy cli command #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we perhaps make the default timeout 0 / no timeout? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #1714
Changes:
--timeout(-t) flag to proxy cli command asskywire-cli proxy start --timeout 30--timeout(-t) flag to vpn cli command asskywire-cli vpn start -t 30Note: Default value of timeout is 20 second. If you pass zero value as
skywire-cli proxy start -t 0then no timeout be there, for both vpn and proxy command.How to test this PR:
skywire-cli proxy start --pk 0326978f5a53aff537dbb47fed58b1f123af3b00132d365f1309a14db4168dcff7 -t 2, it should stop after two second. (Note: key here is dummy, not valid proxy server)