Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | http-proxy on skysocks-client #1728

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Feb 6, 2024

Did you run make format && make check? Yes

Fixes #1696

Changes:

  • add -http argument to skysocks-client config, as address of http-proxy binding (not available for no on UI, just available on config code or by cli)
  • add --http-proxy or -p flag to skywire-cli proxy start to pass http-proxy address to skysocks-client
  • update CHANGELOG.md and dmsg@v1.3.17 and prepare for new release

How to test this PR:

  • run visor and make transport to itself by dmsg
  • run proxy by skywire-cli proxy start -p :1081 -k <visor-pk>
  • check http proxy on app like Mozilla Firefox network setting

@mrpalide mrpalide mentioned this pull request Feb 6, 2024
@mrpalide mrpalide merged commit e4f31dc into skycoin:develop Feb 6, 2024
3 checks passed
@mrpalide mrpalide deleted the feat/http-proxy-to-skysocks-client branch March 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants