Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route re-creation on rule removal through hypervisor API #179

Merged
merged 5 commits into from
Mar 3, 2020
Merged

Fix route re-creation on rule removal through hypervisor API #179

merged 5 commits into from
Mar 3, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Mar 2, 2020 •
edited
Loading

Did you run make format && make check?
Yes
Fixes #161

Changes:

  • Now forward rules are not being removed, cause their activity gets updated correctly
  • On consume rule removal route group gets closed now

How to test this PR:
Run steps as described in #161

nkryuchkov
nkryuchkov approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

evanlinjin
evanlinjin approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, I feel #166 fixes #161 . But these look like helpful changes.

@Darkren Darkren changed the title [WIP] Fix route re-creation on rule removal through hypervisor API Fix route re-creation on rule removal through hypervisor API Mar 3, 2020
@jdknives jdknives merged commit f39e26e into skycoin:milestone2 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Routes are not being created again
4 participants
@Darkren @evanlinjin @nkryuchkov @jdknives