Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #189

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Update Makefile #189

merged 3 commits into from
Mar 4, 2020

Conversation

jdknives
Copy link
Member

@jdknives jdknives commented Mar 4, 2020

Did you run make format && make check?

Fixes issue with make install.

Changes:

  • get rid of install instruction for dmsgpty as it was moved out

How to test this PR:

make build; make install

@@ -59,7 +59,7 @@ clean: ## Clean project: remove created binaries and apps
-rm -f ./skywire-visor ./skywire-cli ./setup-node ./hypervisor

install: ## Install `skywire-visor`, `skywire-cli`, `hypervisor`, `dmsgpty`
${OPTS} go install ${BUILD_OPTS} ./cmd/skywire-visor ./cmd/skywire-cli ./cmd/setup-node ./cmd/hypervisor ./cmd/dmsgpty
${OPTS} go install ${BUILD_OPTS} ./cmd/skywire-visor ./cmd/skywire-cli ./cmd/setup-node ./cmd/hypervisor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please update the comment above?

@jdknives jdknives merged commit 6bf1d84 into milestone2 Mar 4, 2020
@jdknives jdknives deleted the jdknives-patch-1 branch March 4, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants