Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some panics #200

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Remove some panics #200

merged 2 commits into from
Mar 6, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? yes

Partially fixes #186

Changes:

  • Remove some panics

How to test this PR:
make check

evanlinjin
evanlinjin suggested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel some panics are appropriate. I think panics should be used to identify issues with the use of code base.

pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/snet/network.go Show resolved Hide resolved
pkg/visor/rpc.go Show resolved Hide resolved
@nkryuchkov nkryuchkov requested a review from evanlinjin March 5, 2020 11:44
evanlinjin
evanlinjin approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@evanlinjin evanlinjin merged commit 857d105 into skycoin:milestone2 Mar 6, 2020
@nkryuchkov nkryuchkov deleted the fix/remove-panics branch March 13, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Darkren Darkren Awaiting requested review from Darkren

@Kifen Kifen Awaiting requested review from Kifen

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of panics where possible
3 participants
@nkryuchkov @Darkren @evanlinjin