Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify public key before requesting routes #211

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Verify public key before requesting routes #211

merged 3 commits into from
Mar 6, 2020

Conversation

Kifen
Copy link
Contributor

@Kifen Kifen commented Mar 6, 2020

Did you run make format && make check?
Yes
Fixes #172

Changes:

  • Verified public key before call to (*router).DialContext in (*SkywireNetworker).DialContext

How to test this PR: Run the integaration-env, runmake integration-startup, open http://localhost:8000/ and type a message. Then check associated visor for logs.

pkg/app/appnet/skywire_networker.go Outdated Show resolved Hide resolved
@evanlinjin evanlinjin merged commit 6c263df into skycoin:milestone2 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is possible to request routes to invalid public keys.
2 participants