Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send router packets asynchronously #223

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Send router packets asynchronously #223

merged 3 commits into from
Mar 12, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #178

Changes:

  • Send router packets asynchronously

How to test this PR:

  1. make check
  2. Integration env

evanlinjin
evanlinjin suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

pkg/router/router.go Outdated Show resolved Hide resolved
pkg/router/route_group.go Outdated Show resolved Hide resolved
pkg/router/route_group.go Outdated Show resolved Hide resolved
@nkryuchkov nkryuchkov requested a review from evanlinjin March 11, 2020 18:29
evanlinjin
evanlinjin approved these changes Mar 12, 2020
View reviewed changes
pkg/router/router.go Outdated Show resolved Hide resolved
@nkryuchkov nkryuchkov merged commit 27e1672 into skycoin:develop Mar 12, 2020
@nkryuchkov nkryuchkov deleted the feature/async-router-packets branch March 13, 2020 17:37
This was referenced Apr 1, 2020
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Darkren Darkren Awaiting requested review from Darkren

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkryuchkov @evanlinjin