Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a prod build problem with the manager #232

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Fix a prod build problem with the manager #232

merged 2 commits into from
Mar 20, 2020
+515 −115

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
Yes

Changes:

  • A problem while creating prod builds was solved.

How to test this PR:
Run npm run build to compile the manager.

@Senyoret1
Copy link
Contributor Author

I also updated the dist folder, so there is not really need for recompiling the manager for testing

@jdknives jdknives requested a review from Darkren March 20, 2020 10:59
jdknives
jdknives approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@jdknives jdknives merged commit 8d436df into skycoin:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@Darkren Darkren Awaiting requested review from Darkren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senyoret1 @jdknives