Fix dmsgpty in manager UI #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Darkren I made some tests and was able to run the terminal with tls and auth active with the change made on #258 . I'm not very familiar with the go code, so it would be good if you can take a look at that PR and check what can be done with it and what you have investigated. Also, please take a quick look at #248 (comment) |
jdknives
approved these changes
Mar 27, 2020
nkryuchkov
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Yes
Fixes #248
Changes:
HTTPOnly,SecureandSameSitefields.SameSiteis not allowed to be changed for simplicity,HTTPOnlyandSecureare calculated from theEnableTLSvalue of hypervisor's config