Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ports for skychat, skysocks, hypervisor API/UI #294

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Apr 2, 2020

Did you run make format && make check? Yes

Depends on https://github.com/SkycoinPro/skywire-services/pull/142

Fixes #290

Changes:

  • Change ports for
    • skychat
    • skysocks
    • hypervisor API and UI
  • Change the above ports in frontend (@Senyoret1 Could you please have a look if everything is correct?)

How to test this PR:

  • Run the integration environment and check if everything works

@jdknives
Copy link
Member

jdknives commented Apr 2, 2020

Seems to make all the relevant changes, but since the changes from #291 are not included yet, the proxy was not actually working. Still think it is safe to merge.

@nkryuchkov nkryuchkov marked this pull request as ready for review April 2, 2020 10:33
@jdknives jdknives merged commit a678dd3 into skycoin:develop Apr 2, 2020
@nkryuchkov nkryuchkov deleted the fix/change-ports branch April 3, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants