Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change json.NewDecoder to json.Unmarshal in binaries #308

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Change json.NewDecoder to json.Unmarshal in binaries #308

merged 3 commits into from
Apr 7, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? Yes

Changes:

  • Change json.NewDecoder to json.Unmarshal in binaries to avoid EOF errors
  • Add extra logs

How to test this PR:

  • Run integration env

@nkryuchkov nkryuchkov requested a review from jdknives April 7, 2020 15:21
@jdknives jdknives merged commit d5a2515 into skycoin:master Apr 7, 2020
@nkryuchkov nkryuchkov deleted the fix/json-unmarshaling branch July 15, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkryuchkov @jdknives