-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a holepunch transport #313
Merged
nkryuchkov
merged 45 commits into
skycoin:develop
from
nkryuchkov:feature/holepunch-transport
May 30, 2020
Merged
Implement a holepunch transport #313
nkryuchkov
merged 45 commits into
skycoin:develop
from
nkryuchkov:feature/holepunch-transport
May 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
force-pushed
the
feature/holepunch-transport
branch
from
April 30, 2020 21:06
ee47095
to
becabe8
Compare
nkryuchkov
force-pushed
the
feature/holepunch-transport
branch
from
May 5, 2020 10:45
becabe8
to
e32bb76
Compare
nkryuchkov
force-pushed
the
feature/holepunch-transport
branch
from
May 7, 2020 11:33
a78db95
to
e4e5e05
Compare
# Conflicts: # README.md # cmd/skywire-cli/commands/visor/gen-config.go # cmd/skywire-visor/commands/root.go # go.mod # go.sum # pkg/app/client.go # pkg/skyenv/values.go # pkg/snet/network.go # pkg/visor/config.go # pkg/visor/rpc.go # pkg/visor/visor.go # vendor/github.com/SkycoinProject/dmsg/client_session.go # vendor/modules.txt
…-args Make AR IP be added to direct routes by VPN client
nkryuchkov
force-pushed
the
feature/holepunch-transport
branch
from
May 20, 2020 18:13
f1cbb35
to
92e71b2
Compare
# Conflicts: # go.mod # internal/vpn/client.go # pkg/skyenv/values.go # pkg/util/pathutil/configpath.go # pkg/visor/config.go # pkg/visor/init.go # vendor/modules.txt
# Conflicts: # pkg/snet/network.go # pkg/visor/init.go # pkg/visor/visorconfig/README.md # vendor/modules.txt
Darkren
suggested changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, huge job. Comments are mostly stylish
# Conflicts: # go.mod # pkg/transport/manager.go
@Darkren Thanks for reviewing. Your requests are resolved. |
Closed
jdknives
pushed a commit
that referenced
this pull request
Oct 19, 2020
* Implement `stcp` with address resolving (`stcpr`) and encryption * Implement `stcp` with TCP hole punching (`stcph`) and encryption * Add encryption for all `stcp` Former-commit-id: d069311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?Fixes #264
Changes:
stcp
with address resolving (stcpr
) and encryptionstcp
with TCP hole punching (stcph
) and encryptionstcp
How to test this PR:
make integration-startup-stcpr
skychat
worksstcph
by runningmake integration-startup-stcph
address-resolver
addresses tohttp://address-resolver.skywire.cc
inVisor{A,B,C}
configs (this does not work with all NATs)