Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the manager #315

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Improvements for the manager #315

merged 2 commits into from
Apr 17, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • Now the state of the transports is shown in the transport list and the transport details modal window. It can also be used for sorting the list.
  • The state of the visors can be used for sorting the visor list.
  • The code was modified to work with the changes made in the Hypervisor to the names of the properties retated to the apps.
  • The modal window for configuring the skysocks-client app now shows the current configuration.
  • The code was modified to work well with the changes made to how the /user API endpoint responds when the auth option is disabled on the Hypervisor.
  • Some additional small changes.

How to test this PR:
Check the new info and sorting options in the transport list and the node list. For the changes made to make the manager work with the lastest version of the hypervisor, check if the app list continues to work and if the manager works well with and without authentication.

NOTE: this PR does not update the compiled files the repo has. For testing, you have to compile the manager it or use the dev server.

@jdknives
Copy link
Member

Bildschirmfoto 2020-04-14 um 18 34 09

This happens when I try to access the apps page of the visor. Happens on Firefox and Safari (inkognito and standard).

@Senyoret1
Copy link
Contributor Author

It is working well for me. I updated the branch, just in case, but I don't really think the problem is related to that. Can you please recompile the front end, check if there are any errors on the browser console and/or give me more details about how are you getting the error?

@jdknives
Copy link
Member

ERROR TypeError: "e.name is undefined"
    recalculateElementsToShow http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    recalculateElementsToShow http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    set http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    kr http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ml http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ml http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ml http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Jl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    nD http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    updateDirectives http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ol http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Pl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Pl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ol http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Pl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ol http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Pl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    El http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Ol http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    xl http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    detectChanges http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    tick http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    invoke http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    onInvoke http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    invoke http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    run http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    run http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    r http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    __tryOrUnsub http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    _next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    emit http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    fo http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    go http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    onInvoke http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    invoke http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    run http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    run http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    updateTimeSubscription http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    __tryOrUnsub http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    _next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    next http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    Rf http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    _execute http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    execute http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    flush http://localhost:8000/main.b5f4e6c06730d4912fe4.js:1
    invokeTask http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    runTask http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    invokeTask http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    invoke http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1
    0 http://localhost:8000/polyfills.4df8e71b7437fd78eac9.js:1

Thats what the console of the browser shows.

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Just got it running and the changes all work smoothly for me.

@jdknives jdknives merged commit 3c50cd4 into skycoin:develop Apr 17, 2020
jdknives added a commit that referenced this pull request Oct 19, 2020
Improvements for the manager

Former-commit-id: 3c50cd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants