-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for the manager #315
Conversation
It is working well for me. I updated the branch, just in case, but I don't really think the problem is related to that. Can you please recompile the front end, check if there are any errors on the browser console and/or give me more details about how are you getting the error? |
Thats what the console of the browser shows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Just got it running and the changes all work smoothly for me.
Improvements for the manager Former-commit-id: 3c50cd4
Did you run
make format && make check
?The go code was not changed.
npm run lint
andnpm run build
were used.Changes:
/user
API endpoint responds when the auth option is disabled on the Hypervisor.How to test this PR:
Check the new info and sorting options in the transport list and the node list. For the changes made to make the manager work with the lastest version of the hypervisor, check if the app list continues to work and if the manager works well with and without authentication.
NOTE: this PR does not update the compiled files the repo has. For testing, you have to compile the manager it or use the dev server.