Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make proxy disc generic #374

Merged
merged 7 commits into from
Jun 1, 2020
Merged

Make proxy disc generic #374

merged 7 commits into from
Jun 1, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented May 25, 2020

Did you run make format && make check?
Yes
Fixes #7 of discovery

Changes:

@Darkren Darkren changed the base branch from master to develop May 25, 2020 16:45
@Darkren Darkren requested review from evanlinjin and nkryuchkov May 25, 2020 16:45
nkryuchkov
nkryuchkov approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

pkg/app/appdisc/factory.go Outdated Show resolved Hide resolved
evanlinjin
evanlinjin suggested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just some requests for some slight tweaks.

pkg/app/appdisc/factory.go Outdated Show resolved Hide resolved
pkg/servicedisc/client.go Outdated Show resolved Hide resolved
@jdknives jdknives merged commit e5d66a1 into skycoin:develop Jun 1, 2020
@jdknives jdknives mentioned this pull request Jun 1, 2020
Closed
jdknives added a commit that referenced this pull request Oct 19, 2020
@jdknives
Merge pull request #374 from Darkren/feature/make-proxy-disc-generic
1c2e5b2 
Make proxy disc generic

Former-commit-id: e5d66a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin requested changes

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darkren @evanlinjin @nkryuchkov @jdknives