Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding trusted visors from config on startup #392

Merged
merged 5 commits into from
Jul 7, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Jun 5, 2020

Did you run make format && make check? yes

Fixes #368

Changes:

  • Add trusted visors from config on startup

How to test this PR:

  • Set branch of skywire-services to https://github.com/SkycoinPro/skywire-services/pull/184
  • Run generic integration env
  • Wait 5 seconds
  • Run ./bin/skywire-cli --rpc $RPC_A visor ls-tp
  • Run ./bin/skywire-cli --rpc $RPC_C visor ls-tp
  • Run ./bin/skywire-cli --rpc $RPC_B visor ls-tp
  • There should be 1 transport on $RPC_A and $RPC_C, 2 transports on $RPC_B; all transports should be up

@nkryuchkov nkryuchkov changed the title Initial work on adding trusted visors Adding trusted visors from config on startup Jun 5, 2020
@nkryuchkov nkryuchkov requested review from evanlinjin, Darkren and jdknives and removed request for evanlinjin and Darkren June 5, 2020 18:28
@nkryuchkov nkryuchkov marked this pull request as ready for review June 5, 2020 18:28
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know your thoughts on my thoughts.

pkg/transport/manager.go Outdated Show resolved Hide resolved
pkg/visor/visor.go Outdated Show resolved Hide resolved
@nkryuchkov nkryuchkov requested a review from evanlinjin July 6, 2020 14:24
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@nkryuchkov nkryuchkov merged commit a2bcbb0 into skycoin:develop Jul 7, 2020
@nkryuchkov nkryuchkov deleted the feature/trusted-visors branch July 7, 2020 14:30
jdknives pushed a commit that referenced this pull request Oct 19, 2020
Adding trusted visors from config on startup

Former-commit-id: a2bcbb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants