Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German Language #399

Merged
merged 15 commits into from
Jun 15, 2020
Merged

Added German Language #399

merged 15 commits into from
Jun 15, 2020

Conversation

4rchim3d3s
Copy link
Contributor

Did you run make format && make check? -> No

Changes:

Added German Language Files

How to test this PR:

run node check.js

@jdknives jdknives changed the base branch from master to develop June 11, 2020 12:15
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke für die Übersetzung! Ich habe gerade einmal über die groben Änderungen geschaut. Gute Arbeit. Ich muss noch einige Änderungen vornehmen, bevor die Übersetzung gemeged werden kann. Ich hoffe, es ist kein Problem, dass ich in Ihre branch gepushed habe. Einige Anmerkungen folgen:

static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
static/skywire-manager-src/src/assets/i18n/de.json Outdated Show resolved Hide resolved
@4rchim3d3s
Copy link
Contributor Author

Habe die Änderungen vorgenommen. Ich arbeite noch nicht lange mit git, weiß also nicht wo ich den Push sehe und wie er sich auswirkt. Denke schon das ist ok :-)

@jdknives
Copy link
Member

@Senyoret1 please have a look at the changes made here and merge if you are happy with them. Language wise, I think this is ready to go for now

@jdknives jdknives merged commit bf070af into skycoin:develop Jun 15, 2020
jdknives added a commit that referenced this pull request Oct 19, 2020
Added German Language

Former-commit-id: bf070af
@4rchim3d3s 4rchim3d3s deleted the patch-1 branch March 26, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants