Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of UDP hole punch transport #400

Merged
merged 23 commits into from
Jun 29, 2020
Merged

Implementation of UDP hole punch transport #400

merged 23 commits into from
Jun 29, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Jun 10, 2020 •
edited
Loading

Did you run make format && make check? Yes

Fixes #394

Changes:

  • Implementation of UDP hole punch transport
  • Partial refactoring of direct transports
  • For transports using address-resolver, if visors use the same IP, they try to establish a connection via local network first.

How to test this PR:

  • Start generic integration env
  • Run make integration-startup-sudph

@nkryuchkov nkryuchkov changed the title WIP: Implementation of UDP hole punch transport Implementation of UDP hole punch transport Jun 10, 2020
This was referenced Jun 15, 2020
Merged
Closed
@nkryuchkov nkryuchkov marked this pull request as ready for review June 26, 2020 17:01
@nkryuchkov
Merge branch 'develop' into feature/sudp-holepunch
ea6b743 
# Conflicts:
#	pkg/snet/network.go
#	pkg/snet/snettest/env.go
#	vendor/modules.txt
@nkryuchkov
Fix conflicts after merging
5013647
Darkren
Darkren reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor questions, some may be of a taste. But anyway, a huge job is done, great!

pkg/snet/arclient/client.go Show resolved Hide resolved
pkg/snet/arclient/client.go Show resolved Hide resolved
pkg/snet/directtransport/client.go Outdated Show resolved Hide resolved
pkg/snet/network.go Show resolved Hide resolved
pkg/snet/sudph/client.go Show resolved Hide resolved
pkg/snet/sudpr/client.go Show resolved Hide resolved
@jdknives jdknives merged commit 5b221e4 into skycoin:develop Jun 29, 2020
@nkryuchkov nkryuchkov deleted the feature/sudp-holepunch branch July 15, 2020 11:16
jdknives added a commit that referenced this pull request Oct 19, 2020
@jdknives
Merge pull request #400 from nkryuchkov/feature/sudp-holepunch
76b0978 
Implementation of UDP hole punch transport

Former-commit-id: 5b221e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren approved these changes

@evanlinjin evanlinjin Awaiting requested review from evanlinjin

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkryuchkov @Darkren @jdknives