Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the UI theme #424

Merged
merged 8 commits into from
Jul 7, 2020
Merged

Update the UI theme #424

merged 8 commits into from
Jul 7, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #260

Changes:

  • This PR changes the theme of the Skywire manager, to make it look like the one in the issue.

How to test this PR:
Check the changes in the Skywire manager.

NOTE: at this point most of the pages have the dark theme, except for the options page. The modal windows have not been changed, so the design still needs improvements.

@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

  • Now the options page of the manager uses the dark theme.
  • Generic styles for making the fields and buttons work well with the dark theme were added.

@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

  • The design of the modal windows was changed to work better with the dark theme.
  • Visual improvements were added to several modal windows, appart from the ones applied to the generic modal window component.
  • The design of the modal window for updating one or all visors at the same time has a lot of changes and some potential problems in edge cases were fixed.
  • A bug with the theme background was solved.
  • A bug with the login page was fixed.
  • Some other small fixes.

@Senyoret1
Copy link
Contributor Author

The last commits include the following changes:

  • SelectOptionComponent was improved and now if replaces several other modal windows, to simplify the code and ensure a more consistent design.
  • An inconsistency with the selection of the default transport, in the transport creation modal window, was solved.
  • A problem with modal windows without scroll bars was solved.
  • A problem with the layout just after initiating navigation from the visor details page was solved.
  • Some other small improvements.

@Senyoret1
Copy link
Contributor Author

The last commits include the following changes:

  • The problem with the Travis test was fixed.
  • The way in which the scss imports are made was changed, to avoid repeated styles.

@jdknives
Copy link
Member

jdknives commented Jul 7, 2020

@Senyoret1 I sent some requests/ideas on TG.

@Senyoret1
Copy link
Contributor Author

The last commit includes the following changes:

  • Now the background is darker.
  • Now the flag button has a white background.
  • Now the menu does not have a clear gradient at the borders.

@jdknives jdknives merged commit c16ab22 into skycoin:develop Jul 7, 2020
jdknives added a commit that referenced this pull request Oct 19, 2020
Update the UI theme

Former-commit-id: c16ab22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants