Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of dmsgpty in visor. #45

Merged
merged 8 commits into from
Nov 6, 2019
Merged

Integration of dmsgpty in visor. #45

merged 8 commits into from
Nov 6, 2019

Conversation

evanlinjin
Copy link
Contributor

@evanlinjin evanlinjin commented Oct 29, 2019 •
edited by jdknives
Loading

Closes #26 Closes #16

@evanlinjin evanlinjin added the enhancement New feature or request label Oct 29, 2019
@evanlinjin evanlinjin changed the title Initial work on integrating dmsgpty in visor. [WIP] Initial work on integrating dmsgpty in visor. Oct 29, 2019
@evanlinjin evanlinjin changed the title [WIP] Initial work on integrating dmsgpty in visor. Integration of dmsgpty in visor. Oct 30, 2019
nkryuchkov
nkryuchkov reviewed Oct 31, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
pkg/dmsgpty/cli.go Outdated Show resolved Hide resolved
pkg/setup/node.go Outdated Show resolved Hide resolved
jdknives
jdknives requested changes Nov 4, 2019
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a line explaining how to start a dmsgpty session with a certain PubKey?

@evanlinjin
Copy link
Contributor Author

Looks good. Could you add a line explaining how to start a dmsgpty session with a certain PubKey?

@jdknives README updated.

@jdknives jdknives merged commit 874aaad into skycoin:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[M1] Integrate dmsgexec and remove skyssh/therealssh. Milestone 1 Production Testing
3 participants
@evanlinjin @nkryuchkov @jdknives