Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app exit on VPN server failure #468

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Make app exit on VPN server failure #468

merged 3 commits into from
Aug 14, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Aug 12, 2020

Did you run make format && make check?
Yes
Fixes #464

Changes:

  • VPN server app now exists if Serve call failed
  • VPN server now exists immediately if run on non-Linux OS

@Darkren Darkren requested a review from nkryuchkov August 12, 2020 14:51
@jdknives
Copy link
Member

@Darkren could we also make the VPN app shut down upon other fatal errors such as starting on MacOS?

[2020-08-12T18:42:26.542659+02:00] INFO (STDERR) [proc:vpn-server:0b7d29c85c5b489ea1e5ea4485f70499]: time="2020-08-12T18:42:26+02:00" level=info msg="Got app listener, bound to 44"
[2020-08-12T18:42:26.718356+02:00] INFO (STDERR) [proc:vpn-server:0b7d29c85c5b489ea1e5ea4485f70499]: time="2020-08-12T18:42:26+02:00" level=fatal msg="Error creating VPN server" error="error getting default network interface: server related methods are not supported for this OS"

But skywire-cli visor ls-apps returns the server as running and it is still shown as running in the hypervisor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants