Add an option for removing all offline transports #486
+74
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?The go code was not changed.
npm run lintandnpm run buildwere used.Changes:
The transport list now has an option for removing all offline transports. This helps to manage large amounts of unused transports when using the vpn apps.
Now the option for removing all offline visors, in the visor list, takes into account the filters and shows an alert informing that. There are also some small UX improvements. The option for removings all offline transports also have those changes.
How to test this PR:
Using the Skywire manager, go to the transport list of a visor. The option is shown by clicking the button with the 3 horizontal dots at the top-right corner of the transport list.