Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN improvements #491

Merged
merged 35 commits into from
Sep 28, 2020
Merged

VPN improvements #491

merged 35 commits into from
Sep 28, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Aug 25, 2020

Did you run make format && make check?
Yes
Fixes #473

Changes:

  • Packet of type NetworkProbe added. Packet handling goes this way. Once an interval of time (3 seconds now) route group sends network probe to the remote. Packet includes timestamp of when the packet was sent and a throughput of the remote. Throughput is an amount of bytes per second successfully delivered to the remote. So the source route group tells remote the throughput of the remote. Upon receiving this packet remote calculates latency based on the timestamp in a packet;
  • Amount of bandwidth sent/receiced is calculated on each sent/received packet;
  • NoiseRouteGroup and SkywireConn are exposed to allow outer code get RG's metrics;
  • IsAlive method is added to route group. RG is considered alive as soon as underlying route is functional;
  • Method to fetch connections metrics for a specific app is added to hypervisor.

How to test this PR:

  1. Run any app. VPN for example
  2. Request data from hypervisor, like this:
http://{HYPERVISOR_URL}/api/visors/{VISOR_PK}/apps/{APP_NAME}/connections

@Darkren Darkren requested a review from nkryuchkov August 25, 2020 18:37
@Darkren Darkren changed the title [WIP] VPN improvements VPN improvements Aug 25, 2020
@Darkren Darkren changed the base branch from develop to feature/v0.4.0 August 28, 2020 09:24
@Darkren Darkren changed the base branch from feature/v0.4.0 to develop September 1, 2020 16:14
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Works great.

pkg/router/network_stats.go Outdated Show resolved Hide resolved
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very smooth. Please respond to the request by Nikita and change target branch to v0.4.0 and then this can go.

@Darkren Darkren changed the base branch from develop to feature/v0.4.0 September 28, 2020 09:22
@jdknives jdknives merged commit ee1fa0e into skycoin:feature/v0.4.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants