-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPN improvements #491
Merged
jdknives
merged 35 commits into
skycoin:feature/v0.4.0
from
Darkren:feature/vpn-improvements
Sep 28, 2020
Merged
VPN improvements #491
jdknives
merged 35 commits into
skycoin:feature/v0.4.0
from
Darkren:feature/vpn-improvements
Sep 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Works great.
jdknives
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very smooth. Please respond to the request by Nikita and change target branch to v0.4.0 and then this can go.
…ure/vpn-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?Yes
Fixes #473
Changes:
NetworkProbe
added. Packet handling goes this way. Once an interval of time (3 seconds now) route group sends network probe to the remote. Packet includes timestamp of when the packet was sent and a throughput of the remote. Throughput is an amount of bytes per second successfully delivered to the remote. So the source route group tells remote the throughput of the remote. Upon receiving this packet remote calculates latency based on the timestamp in a packet;NoiseRouteGroup
andSkywireConn
are exposed to allow outer code get RG's metrics;IsAlive
method is added to route group. RG is considered alive as soon as underlying route is functional;How to test this PR: