Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrent map writes panic #515

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Fix concurrent map writes panic #515

merged 2 commits into from
Sep 11, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #514

Changes:

  • Fix concurrent map writes panic

How to test this PR:

  • Run visor
  • Wait until it's initialized
  • Press Ctrl-C
  • There should be no concurrent map writes panic

@nkryuchkov nkryuchkov linked an issue Sep 9, 2020 that may be closed by this pull request
Concurrent map writes panic #514
Closed
Darkren
Darkren reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get the error from Close first and then lock on mutex? In case the Close call takes a lot of time to complete

@nkryuchkov
Copy link
Contributor Author

@Darkren Good idea, thanks.

@nkryuchkov nkryuchkov requested a review from Darkren September 10, 2020 11:37
@jdknives jdknives merged commit 9a9a7a0 into skycoin:develop Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren approved these changes

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent map writes panic
3 participants
@nkryuchkov @Darkren @jdknives