Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect proxy if yamux session failed #53

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Reconnect proxy if yamux session failed #53

merged 4 commits into from
Nov 11, 2019

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Nov 7, 2019 •
edited
Loading

Fixes #52

Changes:

  • Implement reconnection
  • Adjust broken unit tests for the new implementation

How to test this PR:
Run e2e tests in skywire-services.

@nkryuchkov nkryuchkov changed the title [WIP] Reconnect proxy if yamux session failed Reconnect proxy if yamux session failed Nov 7, 2019
@nkryuchkov nkryuchkov requested a review from evanlinjin November 7, 2019 13:56
@jdknives jdknives requested a review from Darkren November 8, 2019 07:43
Darkren
Darkren suggested changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just minor improvement

internal/therealproxy/client.go Show resolved Hide resolved
evanlinjin
evanlinjin approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Glad the code is now much more understandable.

@jdknives jdknives merged commit 21251cb into skycoin:master Nov 11, 2019
@nkryuchkov nkryuchkov mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkren Darkren Darkren requested changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy client does not work if yamux connection fails
4 participants
@nkryuchkov @Darkren @evanlinjin @jdknives