Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transport from discovery on transport deregister #54

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Nov 7, 2019

Replaces #11
To be merged simultaneously with https://github.com/SkycoinPro/skywire-services/pull/31

@nkryuchkov nkryuchkov changed the title Remove transport from discovery on transport deregister [WIP] Remove transport from discovery on transport deregister Nov 7, 2019
@nkryuchkov nkryuchkov changed the title [WIP] Remove transport from discovery on transport deregister Remove transport from discovery on transport deregister Nov 13, 2019
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Just one thing.

pkg/transport/manager.go Outdated Show resolved Hide resolved
@nkryuchkov nkryuchkov force-pushed the feature/transport-discovery-delete-transport branch from 13bb41d to 9eb25d3 Compare November 13, 2019 08:53
@nkryuchkov nkryuchkov merged commit b225df8 into skycoin:master Nov 13, 2019
@nkryuchkov nkryuchkov deleted the feature/transport-discovery-delete-transport branch March 13, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants