Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change http.ServeMux to chi #546

Merged
merged 6 commits into from
Oct 16, 2020
Merged

Change http.ServeMux to chi #546

merged 6 commits into from
Oct 16, 2020

Conversation

nkryuchkov
Copy link
Contributor

@nkryuchkov nkryuchkov commented Oct 13, 2020 •
edited
Loading

Did you run make format && make check? Yes

Part of https://github.com/SkycoinPro/skywire-services/issues/250
Part of https://github.com/SkycoinPro/skywire-services/issues/263

Depends on skycoin/dmsg#17

Changes:

  • Change http.ServeMux to chi
  • Log time spent in requests
  • Add some useful middlewares
  • Output request IDs

How to test this PR:

  • make check
  • Run integration env and check the changes listed above

@nkryuchkov nkryuchkov marked this pull request as draft October 13, 2020 12:24
@nkryuchkov nkryuchkov marked this pull request as ready for review October 15, 2020 18:12
@nkryuchkov nkryuchkov changed the title Change http.ServeMux to chi [WIP] Change http.ServeMux to chi Oct 16, 2020
@nkryuchkov nkryuchkov changed the title [WIP] Change http.ServeMux to chi Change http.ServeMux to chi Oct 16, 2020
@nkryuchkov nkryuchkov marked this pull request as draft October 16, 2020 13:00
@nkryuchkov nkryuchkov marked this pull request as ready for review October 16, 2020 15:12
@jdknives jdknives merged commit 6454b73 into skycoin:develop Oct 16, 2020
@nkryuchkov nkryuchkov deleted the feature/change-http-servemux-to-chi branch October 16, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@Darkren Darkren Awaiting requested review from Darkren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkryuchkov @jdknives