Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the logout option from the manager if not needed #596

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Remove the logout option from the manager if not needed #596

merged 1 commit into from
Nov 7, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • The logout button is not shown in the manager if the auth features of the backend are not active.

How to test this PR:
Navigate to the server list in the Skywire manager. The menu shown after clicking the upper right button must not show the logout option if the hypervisor does not have the auth option active.

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@jdknives jdknives merged commit 7311ee4 into skycoin:develop Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants