Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some TODO's #613

Merged
merged 4 commits into from
Nov 23, 2020
Merged

Fix some TODO's #613

merged 4 commits into from
Nov 23, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? Yes

WIP on #107
Fixes #600

Changes:

  • Fix some TODO's
  • Change packet logs from info to debug
  • Disable stdout and stderr output while an updater progress bar is shown.

How to test this PR:

  • Run make check
  • Change version in Makefile to v0.1.0
  • Run integration env
  • Run curl -k -d '{"checksums_url":"", "archive_url":"", "channel":"testing", "version":""}' -X POST https://localhost:8000/api/visors/0348c941c5015a05c455ff238af2e57fb8f914c399aab604e9abb5b32b91a4c1fe/update to run updating
  • Check VisorB logs
  • Update should finish successfully and there should be no other logs while a progress bar is shown
    • The latter could be checked by running curl -k -d '{"command":"echo TEST"}' -H 'Content-Type: application/json' -X POST https://localhost:8000/api/visors/0348c941c5015a05c455ff238af2e57fb8f914c399aab604e9abb5b32b91a4c1fe/exec a few times, logs will appear after updating finishes
  • After updating, a new binary should start with a hypervisor config error because the hypervisor is a separate binary in the latest release

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Good job. Probs should be tested on Linux as well.

@taras-skycoin
Copy link
Member

Everything works allright.

@jdknives jdknives merged commit e729863 into skycoin:develop Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants