Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPN server #616

Merged
merged 7 commits into from
Dec 1, 2020
Merged

Fix VPN server #616

merged 7 commits into from
Dec 1, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Nov 23, 2020

Did you run make format && make check?
Yes
Fixes #611

Changes:

  • VPN server now saves current iptables policy for forward chain. The policy gets set to ACCEPT on server start and restored to the original one on server exit.

How to test this PR:

  1. On the server machine run iptables --policy FORWARD DROP, so that packets can't get forwarded out to the Internet
  2. Run VPN server
  3. Run VPN client
  4. Try using VPN

taras-skycoin
taras-skycoin approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@taras-skycoin taras-skycoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPN works.

@jdknives jdknives merged commit cd55711 into skycoin:develop Dec 1, 2020
@jdknives jdknives mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taras-skycoin taras-skycoin taras-skycoin approved these changes

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darkren @taras-skycoin @jdknives