Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the killswitch and secure options to the manager #617

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Add the killswitch and secure options to the manager #617

merged 3 commits into from
Dec 1, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #609

Changes:

  • A checkbox for activating/deactivating the killswitch option was added to the modal window used for configuring the vpn-client app. Additional changes were added to the modal window for being able to add the new configuration option independently from the server selection options.

  • A checkbox for activating/deactivating the secure option was added to the modal window used for configuring the vpn-server app.

Note: changes mentioned in #609 (comment) are needed before finishing the PR.

How to test this PR:
Open the modal windows used for configuring the vpn-client and vpn-server apps and check:

  • If the changes are correctly saved in the visor.
  • If after opening the modal windows the UI shows the options checked or unchecked as appropriate, depending on the current configuration saved in the visor.

@Senyoret1
Copy link
Contributor Author

The last commit includes the changes needed for the PR to work. I tested it and the configuration is saved in the visor, but I think the killswitch will only work after #608 is merged.

@Senyoret1 Senyoret1 changed the title [WIP] Add the killswitch and secure options to the manager Add the killswitch and secure options to the manager Nov 29, 2020
@jdknives
Copy link
Member

jdknives commented Dec 1, 2020

@Senyoret1 good job. Works as expected.

@jdknives jdknives merged commit a3001bb into skycoin:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants