Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark visors with problematic services in the visor list #626

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Mark visors with problematic services in the visor list #626

merged 1 commit into from
Dec 1, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • Now, if one or more services of a visor is not working, the dot shown at the left of the visor in the visor list is shown yellow and blinking, to make it easier to know when a visor has a problem.
  • The code for checking the state of the visor services was changed, to make it centralized and use the same code in the visor details page and the visor list. This was made to make the code more maintainable and to avoid potential errors in the future, if changes are made only in one page.

How to test this PR:
Make one of the visors have trouble connecting with a service (like the uptime tracker or the transport discovery). The affected visor must have a yellow dot at the left in the visor list, instead of the green dot used for indicating that the visor is working well. Also, the “health info” section of the visor details page should continue working well.

@jdknives
Copy link
Member

jdknives commented Dec 1, 2020

Nice effect with the pulsating circle. Well done!

@jdknives jdknives merged commit d403531 into skycoin:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants