New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on server shutdown #633

Merged

jdknives merged 2 commits into skycoin:develop from Darkren:fix/panic-on-visor-close

Dec 7, 2020

Contributor

Darkren commented Dec 7, 2020

Did you run make format && make check?
Yes
Fixes #629

Changes:

Additional case was added to prevent write on closed channel

Darkren added 2 commits

December 7, 2020 21:37


          Fix panic on server shutdown

546eead


          Fix tests

e11edec

Darkren requested review from jdknives and taras-skycoin

December 7, 2020 18:45

taras-skycoin approved these changes

View reviewed changes

Member

taras-skycoin left a comment

Great job! I am not sure how I can reproduce this error, so I did not test it.

jdknives merged commit 9b0c32b into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet