Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app be restarted only once if some arg changed #637

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Make app be restarted only once if some arg changed #637

merged 1 commit into from
Dec 17, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Dec 10, 2020

Did you run make format && make check?
Yes
Fixes #623

Changes:

  • Now app only gets restarted once if some of its args changed via UI

How to test this PR:

  1. Run any app
  2. Change several args at once
  3. App should only be restarted once

@jdknives jdknives mentioned this pull request Dec 15, 2020
Closed
jdknives
jdknives approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly.

@jdknives jdknives merged commit e4ec693 into skycoin:develop Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@taras-skycoin taras-skycoin Awaiting requested review from taras-skycoin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkren @jdknives