Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more info about the routes in the manager #645

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Show more info about the routes in the manager #645

merged 1 commit into from
Dec 22, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #429

Changes:

  • The rule string was removed from the routes list. Now it shows the route type, source and destination.
    rt
  • The route details popup now shows the labels associated with the PKs and IDs, if any.

How to test this PR:
Check the route list of a visor using the Skywire manager.

jdknives
jdknives approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@jdknives jdknives merged commit 2e3d9f8 into skycoin:develop Dec 22, 2020
@jdknives jdknives mentioned this pull request Dec 22, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senyoret1 @jdknives